mirror of
https://github.com/lukaszraczylo/claude-mnemonic.git
synced 2026-10-12 04:55:18 +00:00
055103cb3b
UpdateObservation set updated_at_epoch, but the observations table has no such column, so every PUT /api/observations/{id} failed with HTTP 500 (no such column: updated_at_epoch). Remove the assignment; nothing reads an edited-at time. An update that changes nothing now returns the observation, as intended. UpdateObservation had no tests: add store and handler tests.
Co-authored-by: Claude Sonnet 5.5 <[email protected]>
60 lines
2.2 KiB
Go
60 lines
2.2 KiB
Go
package worker
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func doUpdateRequest(t *testing.T, svc *Service, method, target string, body any) *httptest.ResponseRecorder {
|
|
t.Helper()
|
|
var buf bytes.Buffer
|
|
if body != nil {
|
|
require.NoError(t, json.NewEncoder(&buf).Encode(body))
|
|
}
|
|
rec := httptest.NewRecorder()
|
|
svc.router.ServeHTTP(rec, httptest.NewRequest(method, target, &buf))
|
|
return rec
|
|
}
|
|
|
|
func TestHandleUpdateObservation_EditsAndReturnsTheObservation(t *testing.T) {
|
|
svc, cleanup := testService(t)
|
|
defer cleanup()
|
|
id := createTestObservation(t, svc.observationStore, "proj_aaaaaa", "Old title", "Old narrative", []string{"cache"})
|
|
|
|
rec := doUpdateRequest(t, svc, http.MethodPut, fmt.Sprintf("/api/observations/%d", id),
|
|
map[string]any{"title": "New title", "facts": []string{"one", "two"}})
|
|
require.Equal(t, http.StatusOK, rec.Code, rec.Body.String())
|
|
var resp struct {
|
|
Observation struct {
|
|
Title string `json:"title"`
|
|
Narrative string `json:"narrative"`
|
|
Facts []string `json:"facts"`
|
|
} `json:"observation"`
|
|
}
|
|
require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &resp))
|
|
assert.Equal(t, "New title", resp.Observation.Title)
|
|
assert.Equal(t, "Old narrative", resp.Observation.Narrative)
|
|
assert.Equal(t, []string{"one", "two"}, resp.Observation.Facts)
|
|
|
|
rec = doUpdateRequest(t, svc, http.MethodGet, fmt.Sprintf("/api/observations/%d", id), nil)
|
|
require.Equal(t, http.StatusOK, rec.Code)
|
|
assert.Contains(t, rec.Body.String(), "New title", "the edit is stored")
|
|
}
|
|
|
|
func TestHandleUpdateObservation_Refusals(t *testing.T) {
|
|
svc, cleanup := testService(t)
|
|
defer cleanup()
|
|
id := createTestObservation(t, svc.observationStore, "proj_aaaaaa", "A title", "A narrative", nil)
|
|
|
|
assert.Equal(t, http.StatusNotFound, doUpdateRequest(t, svc, http.MethodPut, "/api/observations/999999", map[string]any{"title": "x"}).Code)
|
|
assert.Equal(t, http.StatusBadRequest, doUpdateRequest(t, svc, http.MethodPut, fmt.Sprintf("/api/observations/%d", id), map[string]any{"scope": "galaxy"}).Code)
|
|
assert.Equal(t, http.StatusBadRequest, doUpdateRequest(t, svc, http.MethodPut, "/api/observations/abc", map[string]any{"title": "x"}).Code)
|
|
}
|