Files
claude-mnemonic/internal/watcher/watcher.go
T
lukaszraczylo 5c2685c7b6 feat(leann-phase2): implement hybrid vector storage and graph-based search (#20)
* feat(leann-phase2): implement hybrid vector storage and graph-based search

- [x] Add AST-aware code chunking for Go, Python, and TypeScript using tree-sitter
- [x] Implement LEANN-inspired hybrid vector storage with hub detection and selective embedding storage (60-80% savings)
- [x] Add observation relationship graph with CSR format and edge detection (file overlap, semantic similarity, temporal, concept)
- [x] Implement graph-aware search with two-level traversal and relationship-based ranking
- [x] Add auto-tuning system for dynamic hub threshold adjustment based on query performance
- [x] Add comprehensive metrics tracking for vector storage, queries, latency, and graph traversals
- [x] Update configuration system with graph and hybrid storage settings
- [x] Add graph stats and vector metrics endpoints to worker service
- [x] Enhance UI sidebar with advanced metrics display and graph visualization
- [x] Optimize struct field alignment throughout codebase for memory efficiency
- [x] Update documentation with LEANN Phase 2 features and performance benefits
- [x] Add tree-sitter dependency for AST parsing

* fix: add fts5 build tag to CI workflow

Pass build-tags: "fts5" to shared workflow to properly compile
sqlite-vec-go-bindings with SQLite FTS5 support.

This fixes test failures in hybrid vector storage tests that require
CGO and FTS5 build tags.

Requires shared-actions@8f7f235 or later.

* docs: add testing documentation and macOS ARM64 known issue

Document the macOS ARM64 CGO linking issue with sqlite-vec-go-bindings
that prevents hybrid package tests from compiling locally.

Added:
- .github/TESTING.md: Comprehensive testing guide with platform-specific
  issues, workarounds, and CI configuration details
- internal/vector/hybrid/README.md: Package-specific documentation
  explaining the macOS limitation
- .github/CI_FIX_SUMMARY.md: Technical details of the CI fix

Key points:
- 41 out of 42 packages test successfully on all platforms
- hybrid package tests fail only on macOS ARM64 (local dev issue)
- Linux CI tests pass with proper build-tags: "fts5" configuration
- Production builds and runtime functionality unaffected

This is a known limitation of sqlite-vec-go-bindings on macOS ARM64
and does not impact CI/CD or production deployments.

* fix: add SQLite busy_timeout to prevent database locked errors

Set PRAGMA busy_timeout=5000 (5 seconds) to allow SQLite to retry
when the database is locked instead of failing immediately.

This fixes race conditions when multiple goroutines try to write
simultaneously, particularly in tests where StoreObservation spawns
async cleanup goroutines.

Root cause:
- StoreObservation launches goroutine -> CleanupOldObservations
- Multiple concurrent cleanups caused "database is locked" errors
- Without busy_timeout, SQLite fails immediately on lock contention

Solution:
- Add 5-second busy timeout for automatic retry on lock
- Standard practice for concurrent SQLite usage
- Works with existing WAL mode configuration

Fixes TestObservationStore_CleanupOldObservations in CI.

* docs: complete summary of all CI test fixes

Comprehensive documentation of all fixes applied:
1. Missing build tags (fts5)
2. Database locked errors (busy_timeout)

All 41/42 packages now pass tests. The hybrid package has a known
macOS ARM64 limitation that doesn't affect CI or production.

No functionality was removed - all fixes are additive only.

* fix: add SQLite driver import to hybrid tests for CGO linking

Add blank import of mattn/go-sqlite3 to hybrid test files to ensure
the SQLite driver is linked into the test binary. This provides the
SQLite symbols that sqlite-vec-go-bindings requires.

Root cause:
- hybrid package imports sqlitevec (transitively depends on sqlite-vec CGO)
- Test binary needs SQLite symbols for linking
- sqlitevec tests already had this import, but hybrid tests didn't
- Without the driver import, linker fails with "undefined symbols"

This fix enables hybrid tests to run with -race flag on all platforms.

Before: 41/42 packages pass (hybrid failed to link)
After:  42/42 packages pass 

Fixes hybrid test compilation on macOS ARM64, Linux, and Windows.

* docs: remove outdated macOS limitation documentation

The hybrid test linking issue has been fixed by adding the SQLite
driver import. All tests now pass on all platforms including macOS.

Removed:
- internal/vector/hybrid/README.md (documented workaround no longer needed)
- .github/TESTING.md (macOS limitation section obsolete)

All 42/42 packages now test successfully with -race flag.

* docs: final comprehensive summary of all CI fixes

All three issues now resolved:
1. Missing fts5 build tags
2. Database busy_timeout for concurrent writes
3. Missing SQLite driver import in hybrid tests

Result: 42/42 packages pass with -race on all platforms.

Credit to reviewer for identifying the race detector concern.
2026-01-07 22:03:59 +00:00

188 lines
4.5 KiB
Go

// Package watcher provides file system watching utilities for detecting
// database file/directory deletions and triggering recreation.
package watcher
import (
"context"
"os"
"path/filepath"
"sync"
"time"
"github.com/fsnotify/fsnotify"
"github.com/rs/zerolog/log"
)
// Watcher monitors a file or directory for deletion and calls onDelete when removed.
// It watches the parent directory since fsnotify cannot watch non-existent files.
type Watcher struct {
ctx context.Context
onDelete func()
watcher *fsnotify.Watcher
cancel context.CancelFunc
targetPath string
parentPath string
debounce time.Duration
mu sync.Mutex
running bool
}
// New creates a new Watcher for the given target path.
// The onDelete callback is called when the target is deleted.
func New(targetPath string, onDelete func()) (*Watcher, error) {
fsw, err := fsnotify.NewWatcher()
if err != nil {
return nil, err
}
ctx, cancel := context.WithCancel(context.Background())
return &Watcher{
targetPath: targetPath,
parentPath: filepath.Dir(targetPath),
onDelete: onDelete,
watcher: fsw,
ctx: ctx,
cancel: cancel,
debounce: 100 * time.Millisecond,
}, nil
}
// Start begins watching for file deletion events.
func (w *Watcher) Start() error {
w.mu.Lock()
if w.running {
w.mu.Unlock()
return nil
}
w.running = true
w.mu.Unlock()
// Add watch on parent directory
if err := w.addWatch(); err != nil {
log.Warn().Err(err).Str("path", w.parentPath).Msg("Failed to add initial watch")
// Continue anyway - we'll try to re-establish later
}
go w.watchLoop()
return nil
}
// Stop stops the watcher.
func (w *Watcher) Stop() error {
w.mu.Lock()
defer w.mu.Unlock()
if !w.running {
return nil
}
w.running = false
w.cancel()
return w.watcher.Close()
}
// addWatch adds the parent directory to the watch list.
func (w *Watcher) addWatch() error {
// Ensure parent exists
if _, err := os.Stat(w.parentPath); os.IsNotExist(err) {
return err
}
return w.watcher.Add(w.parentPath)
}
// watchLoop is the main event loop.
func (w *Watcher) watchLoop() {
var (
debounceTimer *time.Timer
pendingDelete bool
)
for {
select {
case <-w.ctx.Done():
if debounceTimer != nil {
debounceTimer.Stop()
}
return
case event, ok := <-w.watcher.Events:
if !ok {
return
}
// Check if this event is for our target
eventPath := filepath.Clean(event.Name)
targetPath := filepath.Clean(w.targetPath)
// Handle parent directory deletion (entire data dir removed)
if eventPath == w.parentPath && event.Op&fsnotify.Remove != 0 {
log.Info().Str("path", w.parentPath).Msg("Parent directory deleted")
pendingDelete = true
if debounceTimer != nil {
debounceTimer.Stop()
}
debounceTimer = time.AfterFunc(w.debounce, func() {
w.handleDeletion()
})
continue
}
// Handle target file/directory deletion
if eventPath == targetPath && event.Op&fsnotify.Remove != 0 {
log.Info().Str("path", w.targetPath).Msg("Target deleted")
pendingDelete = true
if debounceTimer != nil {
debounceTimer.Stop()
}
debounceTimer = time.AfterFunc(w.debounce, func() {
w.handleDeletion()
})
continue
}
// Handle parent directory recreation (re-establish watch)
if eventPath == w.parentPath && event.Op&fsnotify.Create != 0 {
log.Info().Str("path", w.parentPath).Msg("Parent directory recreated, re-establishing watch")
_ = w.addWatch()
continue
}
// If target was recreated after pending delete, cancel the callback
if pendingDelete && eventPath == targetPath && event.Op&fsnotify.Create != 0 {
log.Info().Str("path", w.targetPath).Msg("Target recreated, cancelling deletion callback")
pendingDelete = false
if debounceTimer != nil {
debounceTimer.Stop()
}
}
case err, ok := <-w.watcher.Errors:
if !ok {
return
}
log.Error().Err(err).Msg("Watcher error")
}
}
}
// handleDeletion calls the onDelete callback and attempts to re-establish the watch.
func (w *Watcher) handleDeletion() {
log.Info().Str("path", w.targetPath).Msg("Triggering deletion callback")
// Call the callback
if w.onDelete != nil {
w.onDelete()
}
// Try to re-establish watch after a short delay (parent may have been recreated)
go func() {
time.Sleep(500 * time.Millisecond)
if err := w.addWatch(); err != nil {
log.Warn().Err(err).Str("path", w.parentPath).Msg("Failed to re-establish watch after deletion")
} else {
log.Info().Str("path", w.parentPath).Msg("Re-established watch after recreation")
}
}()
}