Files
claude-mnemonic/internal/db/gorm/prompt_store.go
T
lukaszraczylo 5c2685c7b6 feat(leann-phase2): implement hybrid vector storage and graph-based search (#20)
* feat(leann-phase2): implement hybrid vector storage and graph-based search

- [x] Add AST-aware code chunking for Go, Python, and TypeScript using tree-sitter
- [x] Implement LEANN-inspired hybrid vector storage with hub detection and selective embedding storage (60-80% savings)
- [x] Add observation relationship graph with CSR format and edge detection (file overlap, semantic similarity, temporal, concept)
- [x] Implement graph-aware search with two-level traversal and relationship-based ranking
- [x] Add auto-tuning system for dynamic hub threshold adjustment based on query performance
- [x] Add comprehensive metrics tracking for vector storage, queries, latency, and graph traversals
- [x] Update configuration system with graph and hybrid storage settings
- [x] Add graph stats and vector metrics endpoints to worker service
- [x] Enhance UI sidebar with advanced metrics display and graph visualization
- [x] Optimize struct field alignment throughout codebase for memory efficiency
- [x] Update documentation with LEANN Phase 2 features and performance benefits
- [x] Add tree-sitter dependency for AST parsing

* fix: add fts5 build tag to CI workflow

Pass build-tags: "fts5" to shared workflow to properly compile
sqlite-vec-go-bindings with SQLite FTS5 support.

This fixes test failures in hybrid vector storage tests that require
CGO and FTS5 build tags.

Requires shared-actions@8f7f235 or later.

* docs: add testing documentation and macOS ARM64 known issue

Document the macOS ARM64 CGO linking issue with sqlite-vec-go-bindings
that prevents hybrid package tests from compiling locally.

Added:
- .github/TESTING.md: Comprehensive testing guide with platform-specific
  issues, workarounds, and CI configuration details
- internal/vector/hybrid/README.md: Package-specific documentation
  explaining the macOS limitation
- .github/CI_FIX_SUMMARY.md: Technical details of the CI fix

Key points:
- 41 out of 42 packages test successfully on all platforms
- hybrid package tests fail only on macOS ARM64 (local dev issue)
- Linux CI tests pass with proper build-tags: "fts5" configuration
- Production builds and runtime functionality unaffected

This is a known limitation of sqlite-vec-go-bindings on macOS ARM64
and does not impact CI/CD or production deployments.

* fix: add SQLite busy_timeout to prevent database locked errors

Set PRAGMA busy_timeout=5000 (5 seconds) to allow SQLite to retry
when the database is locked instead of failing immediately.

This fixes race conditions when multiple goroutines try to write
simultaneously, particularly in tests where StoreObservation spawns
async cleanup goroutines.

Root cause:
- StoreObservation launches goroutine -> CleanupOldObservations
- Multiple concurrent cleanups caused "database is locked" errors
- Without busy_timeout, SQLite fails immediately on lock contention

Solution:
- Add 5-second busy timeout for automatic retry on lock
- Standard practice for concurrent SQLite usage
- Works with existing WAL mode configuration

Fixes TestObservationStore_CleanupOldObservations in CI.

* docs: complete summary of all CI test fixes

Comprehensive documentation of all fixes applied:
1. Missing build tags (fts5)
2. Database locked errors (busy_timeout)

All 41/42 packages now pass tests. The hybrid package has a known
macOS ARM64 limitation that doesn't affect CI or production.

No functionality was removed - all fixes are additive only.

* fix: add SQLite driver import to hybrid tests for CGO linking

Add blank import of mattn/go-sqlite3 to hybrid test files to ensure
the SQLite driver is linked into the test binary. This provides the
SQLite symbols that sqlite-vec-go-bindings requires.

Root cause:
- hybrid package imports sqlitevec (transitively depends on sqlite-vec CGO)
- Test binary needs SQLite symbols for linking
- sqlitevec tests already had this import, but hybrid tests didn't
- Without the driver import, linker fails with "undefined symbols"

This fix enables hybrid tests to run with -race flag on all platforms.

Before: 41/42 packages pass (hybrid failed to link)
After:  42/42 packages pass 

Fixes hybrid test compilation on macOS ARM64, Linux, and Windows.

* docs: remove outdated macOS limitation documentation

The hybrid test linking issue has been fixed by adding the SQLite
driver import. All tests now pass on all platforms including macOS.

Removed:
- internal/vector/hybrid/README.md (documented workaround no longer needed)
- .github/TESTING.md (macOS limitation section obsolete)

All 42/42 packages now test successfully with -race flag.

* docs: final comprehensive summary of all CI fixes

All three issues now resolved:
1. Missing fts5 build tags
2. Database busy_timeout for concurrent writes
3. Missing SQLite driver import in hybrid tests

Result: 42/42 packages pass with -race on all platforms.

Credit to reviewer for identifying the race detector concern.
2026-01-07 22:03:59 +00:00

318 lines
9.7 KiB
Go

// Package gorm provides GORM-based database operations for claude-mnemonic.
package gorm
import (
"context"
"database/sql"
"time"
"gorm.io/gorm"
"gorm.io/gorm/clause"
"github.com/lukaszraczylo/claude-mnemonic/pkg/models"
)
// PromptCleanupFunc is a callback for when prompts are cleaned up.
// Receives the IDs of deleted prompts for downstream cleanup (e.g., vector DB).
type PromptCleanupFunc func(ctx context.Context, deletedIDs []int64)
// MaxPromptsGlobal is the hard limit of prompts across all projects.
const MaxPromptsGlobal = 500
// PromptStore provides user prompt-related database operations using GORM.
type PromptStore struct {
db *gorm.DB
cleanupFunc PromptCleanupFunc
}
// NewPromptStore creates a new prompt store.
func NewPromptStore(store *Store, cleanupFunc PromptCleanupFunc) *PromptStore {
return &PromptStore{
db: store.DB,
cleanupFunc: cleanupFunc,
}
}
// SetCleanupFunc sets the callback for when prompts are deleted during cleanup.
func (s *PromptStore) SetCleanupFunc(fn PromptCleanupFunc) {
s.cleanupFunc = fn
}
// SaveUserPromptWithMatches saves a user prompt with matched observation count.
// Uses INSERT OR IGNORE to be idempotent - duplicate (session, prompt_number) pairs are silently ignored.
// This prevents duplicate prompts when the user-prompt hook fires multiple times.
func (s *PromptStore) SaveUserPromptWithMatches(ctx context.Context, claudeSessionID string, promptNumber int, promptText string, matchedObservations int) (int64, error) {
now := time.Now()
prompt := &UserPrompt{
ClaudeSessionID: claudeSessionID,
PromptNumber: promptNumber,
PromptText: promptText,
MatchedObservations: matchedObservations,
CreatedAt: now.Format(time.RFC3339),
CreatedAtEpoch: now.UnixMilli(),
}
// INSERT OR IGNORE using OnConflict
result := s.db.WithContext(ctx).
Clauses(clause.OnConflict{
Columns: []clause.Column{{Name: "claude_session_id"}, {Name: "prompt_number"}},
DoNothing: true,
}).
Create(prompt)
if result.Error != nil {
return 0, result.Error
}
// If RowsAffected is 0, the insert was ignored (duplicate) - fetch the existing ID
if result.RowsAffected == 0 {
var existing UserPrompt
err := s.db.Where("claude_session_id = ? AND prompt_number = ?", claudeSessionID, promptNumber).
First(&existing).Error
if err != nil {
return 0, err
}
// Return existing ID without triggering cleanup (already handled when first inserted)
return existing.ID, nil
}
// Cleanup old prompts beyond the global limit (async to not block handler)
go func() {
cleanupCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
deletedIDs, _ := s.CleanupOldPrompts(cleanupCtx)
if len(deletedIDs) > 0 && s.cleanupFunc != nil {
s.cleanupFunc(cleanupCtx, deletedIDs)
}
}()
return prompt.ID, nil
}
// CleanupOldPrompts deletes prompts beyond the global limit.
// Keeps the most recent MaxPromptsGlobal prompts.
// Returns the IDs of deleted prompts for downstream cleanup (e.g., vector DB).
func (s *PromptStore) CleanupOldPrompts(ctx context.Context) ([]int64, error) {
// Use a transaction to prevent TOCTOU race condition
var idsToDelete []int64
err := s.db.WithContext(ctx).Transaction(func(tx *gorm.DB) error {
// Find IDs to keep (most recent MaxPromptsGlobal)
var idsToKeep []int64
err := tx.Model(&UserPrompt{}).
Order("created_at_epoch DESC").
Limit(MaxPromptsGlobal).
Pluck("id", &idsToKeep).Error
if err != nil {
return err
}
if len(idsToKeep) == 0 {
return nil
}
// Find IDs to delete (all IDs not in the keep list)
// This happens in the same transaction to prevent race conditions
err = tx.Model(&UserPrompt{}).
Where("id NOT IN ?", idsToKeep).
Pluck("id", &idsToDelete).Error
if err != nil {
return err
}
if len(idsToDelete) == 0 {
return nil
}
// Delete the prompts
return tx.Delete(&UserPrompt{}, idsToDelete).Error
})
if err != nil {
return nil, err
}
return idsToDelete, nil
}
// GetPromptsByIDs retrieves user prompts by a list of IDs.
func (s *PromptStore) GetPromptsByIDs(ctx context.Context, ids []int64, orderBy string, limit int) ([]*models.UserPromptWithSession, error) {
if len(ids) == 0 {
return nil, nil
}
var results []struct {
Project sql.NullString `gorm:"column:project"`
SDKSessionID sql.NullString `gorm:"column:sdk_session_id"`
UserPrompt
}
query := s.db.WithContext(ctx).
Table("user_prompts up").
Select("up.id, up.claude_session_id, up.prompt_number, up.prompt_text, "+
"COALESCE(up.matched_observations, 0) as matched_observations, "+
"up.created_at, up.created_at_epoch, "+
"COALESCE(s.project, '') as project, "+
"COALESCE(s.sdk_session_id, '') as sdk_session_id").
Joins("LEFT JOIN sdk_sessions s ON up.claude_session_id = s.claude_session_id").
Where("up.id IN ?", ids)
// Apply ordering
switch orderBy {
case "date_asc":
query = query.Order("up.created_at_epoch ASC")
case "date_desc", "default", "":
query = query.Order("up.created_at_epoch DESC")
}
// Apply limit
if limit > 0 {
query = query.Limit(limit)
}
err := query.Scan(&results).Error
if err != nil {
return nil, err
}
return toModelUserPromptsWithSession(results), nil
}
// GetAllRecentUserPrompts retrieves recent user prompts across all projects.
func (s *PromptStore) GetAllRecentUserPrompts(ctx context.Context, limit int) ([]*models.UserPromptWithSession, error) {
var results []struct {
Project sql.NullString `gorm:"column:project"`
SDKSessionID sql.NullString `gorm:"column:sdk_session_id"`
UserPrompt
}
query := s.db.WithContext(ctx).
Table("user_prompts up").
Select("up.id, up.claude_session_id, up.prompt_number, up.prompt_text, " +
"COALESCE(up.matched_observations, 0) as matched_observations, " +
"up.created_at, up.created_at_epoch, " +
"COALESCE(s.project, '') as project, " +
"COALESCE(s.sdk_session_id, '') as sdk_session_id").
Joins("LEFT JOIN sdk_sessions s ON up.claude_session_id = s.claude_session_id").
Order("up.created_at_epoch DESC").
Limit(limit)
err := query.Scan(&results).Error
if err != nil {
return nil, err
}
return toModelUserPromptsWithSession(results), nil
}
// GetAllPrompts retrieves all user prompts (for vector rebuild).
func (s *PromptStore) GetAllPrompts(ctx context.Context) ([]*models.UserPromptWithSession, error) {
var results []struct {
Project sql.NullString `gorm:"column:project"`
SDKSessionID sql.NullString `gorm:"column:sdk_session_id"`
UserPrompt
}
query := s.db.WithContext(ctx).
Table("user_prompts up").
Select("up.id, up.claude_session_id, up.prompt_number, up.prompt_text, " +
"COALESCE(up.matched_observations, 0) as matched_observations, " +
"up.created_at, up.created_at_epoch, " +
"COALESCE(s.project, '') as project, " +
"COALESCE(s.sdk_session_id, '') as sdk_session_id").
Joins("LEFT JOIN sdk_sessions s ON up.claude_session_id = s.claude_session_id").
Order("up.id")
err := query.Scan(&results).Error
if err != nil {
return nil, err
}
return toModelUserPromptsWithSession(results), nil
}
// FindRecentPromptByText finds a recent prompt by exact text match within a time window.
// Returns (promptID, promptNumber, found).
func (s *PromptStore) FindRecentPromptByText(ctx context.Context, claudeSessionID, promptText string, withinSeconds int) (int64, int, bool) {
cutoffEpoch := time.Now().Add(-time.Duration(withinSeconds) * time.Second).UnixMilli()
var prompt UserPrompt
err := s.db.WithContext(ctx).
Where("claude_session_id = ? AND prompt_text = ? AND created_at_epoch >= ?",
claudeSessionID, promptText, cutoffEpoch).
Order("created_at_epoch DESC").
First(&prompt).Error
if err != nil {
return 0, 0, false
}
return prompt.ID, prompt.PromptNumber, true
}
// GetRecentUserPromptsByProject retrieves recent user prompts for a specific project.
func (s *PromptStore) GetRecentUserPromptsByProject(ctx context.Context, project string, limit int) ([]*models.UserPromptWithSession, error) {
var results []struct {
Project sql.NullString `gorm:"column:project"`
SDKSessionID sql.NullString `gorm:"column:sdk_session_id"`
UserPrompt
}
query := s.db.WithContext(ctx).
Table("user_prompts up").
Select("up.id, up.claude_session_id, up.prompt_number, up.prompt_text, "+
"COALESCE(up.matched_observations, 0) as matched_observations, "+
"up.created_at, up.created_at_epoch, "+
"COALESCE(s.project, '') as project, "+
"COALESCE(s.sdk_session_id, '') as sdk_session_id").
Joins("LEFT JOIN sdk_sessions s ON up.claude_session_id = s.claude_session_id").
Where("s.project = ?", project).
Order("up.created_at_epoch DESC").
Limit(limit)
err := query.Scan(&results).Error
if err != nil {
return nil, err
}
return toModelUserPromptsWithSession(results), nil
}
// toModelUserPromptsWithSession converts query results to pkg/models.UserPromptWithSession.
func toModelUserPromptsWithSession(results []struct {
Project sql.NullString `gorm:"column:project"`
SDKSessionID sql.NullString `gorm:"column:sdk_session_id"`
UserPrompt
}) []*models.UserPromptWithSession {
prompts := make([]*models.UserPromptWithSession, len(results))
for i, r := range results {
project := ""
if r.Project.Valid {
project = r.Project.String
}
sdkSessionID := ""
if r.SDKSessionID.Valid {
sdkSessionID = r.SDKSessionID.String
}
prompts[i] = &models.UserPromptWithSession{
UserPrompt: models.UserPrompt{
ID: r.ID,
ClaudeSessionID: r.ClaudeSessionID,
PromptNumber: r.PromptNumber,
PromptText: r.PromptText,
MatchedObservations: r.MatchedObservations,
CreatedAt: r.CreatedAt,
CreatedAtEpoch: r.CreatedAtEpoch,
},
Project: project,
SDKSessionID: sdkSessionID,
}
}
return prompts
}