lukaszraczylo/claude-mnemonic
1
0
Fork 0
mirror of https://github.com/lukaszraczylo/claude-mnemonic.git synced 2026-10-12 04:55:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(lint): clear the two findings left by #69 and #70 (#72)

Browse Source 
- observation_update_test.go (#69) lacked the fts5 build tag its helper
  (testObservationStore, in observation_store_test.go) has, so `go vet ./...`
  without tags failed with "undefined: testObservationStore".
- Client.knn (#70) concatenates its WHERE clause into the query. The clause is
  built only from constant text with "?" placeholders (see nearest) and every
  value goes through args, so gosec's G202 is a false positive; annotate it the
  way the file already annotates G201.

Co-authored-by: Claude Sonnet 5.5 <[email protected]>
This commit is contained in:
Holger Reinhardt
2026-10-06 20:32:14 +01:00
committed by GitHub
co-authored by Claude Sonnet 5.5
parent fbe938fef2
commit 8c2c69582a
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/db/gorm/observation_update_test.go
+2
View File
@@ -1,3 +1,5 @@
//go:build fts5
package gorm package gorm
import ( import (
internal/vector/sqlitevec/client.go
+1
View File
@@ -526,6 +526,7 @@ func (c *Client) nearest(ctx context.Context, queryBlob []byte, docType, project
// knn runs one vec0 nearest-neighbour query. where holds the MATCH and filters vec0 can answer on their own. // knn runs one vec0 nearest-neighbour query. where holds the MATCH and filters vec0 can answer on their own.
func (c *Client) knn(ctx context.Context, where string, args []any, limit int) ([]QueryResult, error) { func (c *Client) knn(ctx context.Context, where string, args []any, limit int) ([]QueryResult, error) {
// #nosec G202 -- where is built from constant clauses with "?" placeholders only (see nearest); every value goes via args
rows, err := c.db.QueryContext(ctx, rows, err := c.db.QueryContext(ctx,
"SELECT doc_id, distance, sqlite_id, doc_type, field_type, project, scope FROM vectors"+where+" ORDER BY distance LIMIT ?", "SELECT doc_id, distance, sqlite_id, doc_type, field_type, project, scope FROM vectors"+where+" ORDER BY distance LIMIT ?",
append(append([]any{}, args...), limit)...) append(append([]any{}, args...), limit)...)