From 0bbba6c0785ae7d24cba3a07c615021851ab95ee Mon Sep 17 00:00:00 2001
From: Lukasz Raczylo <lukasz@raczylo.com>
Date: Wed, 30 Sep 2026 01:29:07 +0100
Subject: [PATCH] perf(hooks): satisfy fieldalignment, annotate embedded
 gunzip; docs: journal experiments

---
 experiments.md                | 29 +++++++++++++++++++++++++++++
 internal/embedding/service.go |  1 +
 pkg/hooks/httpclient.go       |  2 +-
 3 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/experiments.md b/experiments.md
index 3061b70..a40bfba 100644
--- a/experiments.md
+++ b/experiments.md
@@ -12,6 +12,35 @@ Mutate: Go code and build flags. Frozen: public API, DB schema, plugin manifest.
 | 02 | pkg/hooks: raw HTTP/1.0 client replaces net/http | 87603952 | -14.7% | KEEP |
 | 03 | statusline: shared client, drop net/http | 84531056 | -3.5% vs 02 | KEEP |
 | 04 | embed gzipped ONNX runtime libs, gunzip at first use | 57216880 | -32.3% vs 03 | KEEP |
+| 05 | hooks built with CGO_ENABLED=0 | 57216880 | 0% | revert (not applied) |
+| - | statically dedupe or compress tokenizer.json | - | projected ~1.2-1.6% | not run, under 3% threshold |
+| - | drop net/http from mcp | - | none possible | not run, oss-telemetry links net/http |
+
+Campaign B stopped on diminishing returns: 102698416 -> 57216880 bytes (-44.3%).
+
+## Campaign A: hook latency (stub worker, 200 runs, p50)
+
+Harness: hook binary against a local stub worker (100-observation context), same machine, alternating runs. Lower is better.
+
+| hook | before (ee28544) | after trial 02 | delta |
+|------|------------------|----------------|-------|
+| session-start | 4.6-5.6 ms | 3.3 ms | -30% or better |
+| user-prompt | 4.3-4.7 ms | 3.5-3.7 ms | -15% to -22% |
+
+Hooks now sit near the process-start floor. No further trials run.
+
+## Campaign D: reliability
+
+Metric: failing cases in the extraction fault test (`TestWriteGunzipped`). Lower is better.
+
+| id | mutation | failing cases | kept? |
+|----|----------|---------------|-------|
+| 01 | baseline (truncated archive leaves partial lib.so) | 1 | base |
+| 02 | extract via temp file and rename | 0 | KEEP |
+
+## Campaign C: search accuracy
+
+Not run. It needs a fixed observation corpus, a labelled query set and the downloaded embedding model. Building that eval set is a separate task.
 
 Notes:
 - Trial 04 needs `scripts/download-onnx-libs.sh` to produce `.gz` files; existing raw libs trigger a re-download.
diff --git a/internal/embedding/service.go b/internal/embedding/service.go
index b5b8bd0..e1e5fd7 100644
--- a/internal/embedding/service.go
+++ b/internal/embedding/service.go
@@ -647,6 +647,7 @@ func writeGunzipped(path string, gz []byte) (err error) {
 		}
 	}()
 
+	// #nosec G110 -- archive is embedded at build time, not external input
 	if _, err = io.Copy(f, zr); err != nil {
 		_ = f.Close()
 		return err
diff --git a/pkg/hooks/httpclient.go b/pkg/hooks/httpclient.go
index 2d0da5e..a95435d 100644
--- a/pkg/hooks/httpclient.go
+++ b/pkg/hooks/httpclient.go
@@ -21,9 +21,9 @@ const maxResponseBytes = 32 << 20
 // makes the server skip chunked encoding and close the connection, so the body
 // is simply everything after the header block.
 type httpResponse struct {
-	Status     int
 	StatusText string
 	Body       []byte
+	Status     int
 }
 
 func httpDo(ctx context.Context, timeout time.Duration, method string, port int, path string, body []byte) (*httpResponse, error) {